Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improving Neumorphic ToggleSwitch #1044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Improving Neumorphic ToggleSwitch #1044

wants to merge 1 commit into from

Conversation

eriklimakc
Copy link
Contributor

GitHub Issue (If applicable): closes #1033 and #1034

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on Skia.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

@eriklimakc eriklimakc self-assigned this Nov 6, 2023
@eriklimakc eriklimakc linked an issue Nov 6, 2023 that may be closed by this pull request
[Gallery-4X & 5X][All Platforms]-Neumorphic style- Right Icon is missing for enabled Toggleswitch button in 'ON' positon #1034
Open
@eriklimakc eriklimakc force-pushed the dev/erli/1033/1034-Adjust-Nmp-ToggleSwitch branch from 79e5895 to bdc4dd1 Compare June 5, 2024 12:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net

@agneszitte
Copy link
Contributor

agneszitte commented Jun 7, 2024 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net

@kazo0, @eriklimakc, @Xiaoy312 Can you help test the stage site page of this PR please
(@eriklimakc can you see the same issues locally for WebAssembly?)
On my side I can see weird behavior for wasm:
image
Try to change the control using the combobox as well...
image

@agneszitte
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net

@kazo0, @eriklimakc, @Xiaoy312 Can you help test the stage site page of this PR please (@eriklimakc can you see the same issues locally for WebAssembly?) On my side I can see weird behavior for wasm: image Try to change the control using the combobox as well... image

@morning4coffe-dev can you help qa/test the static web app link + changes locally to see if you can reproduce the issues I am seeing on the static web app link on my side please

@morning4coffe-dev
Copy link
Member

@agneszitte @eriklimakc Both locally on WASM and on the static web app, I can see similar behavior. When I try to open the ComboBox for neum. styles, the UI dissapears for me. For both tests using Edge latest stable.

Local

Recording.2024-06-10.232027.mp4

Azure

Recording.2024-06-10.231021.mp4

@agneszitte
Copy link
Contributor

@agneszitte @eriklimakc Both locally on WASM and on the static web app, I can see similar behavior. When I try to open the ComboBox for neum. styles, the UI dissapears for me. For both tests using Edge latest stable.

Thank you a lot for the test @morning4coffe-dev, is this also happening on latest master please? or it is just related to this PR ?

@morning4coffe-dev
Copy link
Member

@agneszitte I tried to check with all the controls in the ComboBox, but I can't reporduce this Issue on latest master. The UI renders normally:
image

@agneszitte agneszitte marked this pull request as draft June 11, 2024 14:35
@agneszitte
Copy link
Contributor

agneszitte commented Jun 11, 2024 •
edited
Loading

@agneszitte I tried to check with all the controls in the ComboBox, but I can't reporduce this Issue on latest master. The UI renders normally

@eriklimakc I switched this PR as Draft until it is figured out what is happening with the current changes here based on the latest feedback from @morning4coffe-dev that it does not happen on latest master.

@eriklimakc eriklimakc force-pushed the dev/erli/1033/1034-Adjust-Nmp-ToggleSwitch branch from bdc4dd1 to 833c01d Compare June 12, 2024 11:07
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1044.eastus2.3.azurestaticapps.net

@eriklimakc
Copy link
Contributor Author

@morning4coffe-dev @agneszitte I rebased from master and I couldn't reproduce it anymore. Could be that some of the changes made in master fixed it?

Can you please retest it?

@morning4coffe-dev
Copy link
Member

@eriklimakc @agneszitte Jup, I can't no longer reproduce it either on this branch:
image

@eriklimakc eriklimakc marked this pull request as ready for review June 13, 2024 08:42
@agneszitte
Copy link
Contributor

@eriklimakc @agneszitte Jup, I can't no longer reproduce it either on this branch

@eriklimakc and @morning4coffe-dev I am not able to reproduce the issue either now when testing the static web app link associated with the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carldebilly carldebilly carldebilly left review comments

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@agneszitte agneszitte agneszitte approved these changes

@morning4coffe-dev morning4coffe-dev morning4coffe-dev approved these changes

@kazo0 kazo0 Awaiting requested review from kazo0

Assignees

@eriklimakc eriklimakc

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@eriklimakc @agneszitte @morning4coffe-dev @Xiaoy312 @carldebilly